Hide async_gen_internals from standard library documentation#123528
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 6, 2024
Merged
Hide async_gen_internals from standard library documentation#123528bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @Nilstrieb rustbot has assigned @Nilstrieb. Use |
rustbot
added
S-waiting-on-review
Contributor
|
🤦 Whoops. Sorry.
This is correct @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 6, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#123294 (Require LLVM_CONFIG to be set in rustc_llvm/build.rs) - rust-lang#123467 (MSVC targets should use COFF as their archive format) - rust-lang#123498 (explaining `DefKind::Field`) - rust-lang#123519 (Improve cfg and check-cfg configuration) - rust-lang#123525 (CFI: Don't rewrite ty::Dynamic directly) - rust-lang#123526 (Do not ICE when calling incorrectly defined `transmute` intrinsic) - rust-lang#123528 (Hide async_gen_internals from standard library documentation) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 6, 2024
Rollup merge of rust-lang#123528 - dtolnay:asyncgeninternals, r=compiler-errors Hide async_gen_internals from standard library documentation These are from rust-lang#118420. It doesn't appear that there is any intention to ever make these APIs available to user code. These are just conveniences meant for the compiler's implementation of `async gen`. I don't think having them featured in documentation in <https://doc.rust-lang.org/1.77.1/core/task/enum.Poll.html> is appropriate. 
dtolnay
added
A-async-await
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are from #118420. It doesn't appear that there is any intention to ever make these APIs available to user code. These are just conveniences meant for the compiler's implementation of
async gen. I don't think having them featured in documentation in https://doc.rust-lang.org/1.77.1/core/task/enum.Poll.html is appropriate.